fix: include left-side effect of optional chaining in the end of hasEffectsAsChainElement (#5642)

include left-side effect of optional chaining in the end of hasEffectsAsChainElement

Author: TrickyPi

src/ast/nodes/CallExpression.ts

@@ -106,7 +106,8 @@ export default class CallExpression
 		}
 		return (
 			!this.annotationPure &&
-			this.callee.hasEffectsOnInteractionAtPath(EMPTY_PATH, this.interaction, context)
+			(calleeHasEffects ||
+				this.callee.hasEffectsOnInteractionAtPath(EMPTY_PATH, this.interaction, context))
 		);
 	}
 

src/ast/nodes/MemberExpression.ts

@@ -296,7 +296,7 @@ export default class MemberExpression
 		}
 		// We only apply deoptimizations lazily once we know we are not skipping
 		if (!this.deoptimized) this.applyDeoptimizations();
-		return this.property.hasEffects(context) || this.hasAccessEffect(context);
+		return objectHasEffects || this.property.hasEffects(context) || this.hasAccessEffect(context);
 	}
 
 	hasEffectsAsAssignmentTarget(context: HasEffectsContext, checkAccess: boolean): boolean {

test/form/samples/optional-chaining-with-smallest-treeshake/_config.js

@@ -0,0 +1,6 @@
+module.exports = defineTest({
+	description: 'preserve optional chaining with smallest treeshake',
+	options: {
+		treeshake: 'smallest'
+	}
+});

test/form/samples/optional-chaining-with-smallest-treeshake/_expected.js

@@ -0,0 +1,2 @@
+while (global[++i]?.key) {} //retained
+while (global(++i)?.key) {} //retained

test/form/samples/optional-chaining-with-smallest-treeshake/main.js

@@ -0,0 +1,2 @@
+while (global[++i]?.key) {} //retained
+while (global(++i)?.key) {} //retained