Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclipse create review request bug #88

Open
fai58 opened this issue Jan 10, 2012 · 6 comments
Open

Subclipse create review request bug #88

fai58 opened this issue Jan 10, 2012 · 6 comments

Comments

@fai58
Copy link

fai58 commented Jan 10, 2012

When trying to create a review request, it is fine when getting any file changes, but it doesn't show any newly added files

@rombert
Copy link
Owner

rombert commented Jan 17, 2012

Have you tried performing Team -> Add on the new files before creating the review request?

@fai58
Copy link
Author

fai58 commented Jan 18, 2012

Yeah, found it couple days ago, sorry for submitting the bug request, and very nice work you've got there.

On Jan 17, 2012, at 5:18 PM, Robert [email protected] wrote:

Have you tried performing Team -> Add on the new files before creating the review request?


Reply to this email directly or view it on GitHub:
#88 (comment)

@rombert
Copy link
Owner

rombert commented Jan 18, 2012

Good to hear that it works for you know. And thanks :-)

@rombert rombert closed this as completed Jan 18, 2012
@georgeranjan
Copy link

Am still getting this problem. Although the list shown on create review request click does show the new file, the file does not seem to be actually added when you view the submitted request, either in mylyn or the web interface.

@georgeranjan
Copy link

Note that this was tried with subversion server version 1.5 and subclipse 1.6_X. subclipse 1.4 does not seem to be supported by this plugin. Do you think that it is an incompatibility of the subversion client and server?

@rombert rombert reopened this Feb 10, 2012
@rombert
Copy link
Owner

rombert commented Feb 10, 2012

If you still get the problem, please capture the http traffic ( e.g. using wireshark ) between you and the reviewboard instance and attach it somewhere .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants