Support Multiple Line Selection for Comments

[RunnersReign]

When making a comment on a code diff using the Eclipse Plugin, I would normally select multiple lines that I want to make the comment on and then make the comment on that block of text. This is great for instances where you want to show the entire section of code that will cause the error. I finding however that the the comment only refers to the first line of the selection when creating the comment, not the entire highlighted selection.

Steps to Reproduce:

• View a review in Eclipse
• Select multiple lines to make a comment on.
• Right click and select "Add Comment"
• Enter in text and click "Ok"
• Post comment to server.

If you open the review within the Review Board web application, you can see only the first line selected is shown as having a comment associated with it.

It would be a great if all lines selected would be commented on instead of just the first line.

[rombert]

Thanks for raising this issue. We build on the support from the Mylyn Reviews project, so this might not be implemented upstream. I'll check and see if we can do something locally.

[ittaiz]

Any news?
During code review I'd like to comment on a method and not a specific line or the entire commit

[rombert]

No, this still has not been implemented.

On Tue, Mar 25, 2014 at 10:00 AM, Ittai Zeidman [email protected]:

Any news?
During code review I'd like to comment on a method and not a specific line
or the entire commit

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/92#issuecomment-38538660
.

http://robert.muntea.nu/

[brianmrock]

This would be a great feature +1 from me.

[bc-shusson]

+1

[JustDerb]

+1

[codemedic]

+1

[rainulf]

+1

[bwplotka]

+1

[TroldeJens]

+1

[tj-recess]

+1

[ryanrolds]

+1

[bg-o]

+1

[kavirajk]

+1

[ttddyy]

+1

[yotamoron]

+1

[emckenna]

yes please

[cybersam]

+1

[aarosil]

+1

[samuelmburu]

+1

[ulisesbocchio]

+1

[mktal]

+1

[jpotte1d]

+1

[baras]

+1

[jeremy-techson]

+1

[ebrause]

+1

[meanmina]

+1

[flopex]

+1

[alexissan]

+1

[Stadler76]

+1

[stascrash]

Hi, Yes i do wish we had this feature, considering it was first mentioned in 2012.

+1

[pbukva]

This is very useful feature, it has been impleemnted by other review tools for years by now (for instance in Phabricator).
I don't want to sound like old farty whine here, but it is quite a shame this feature request is hanging here since 2012 ...

+1

@Kingdutch : I did thumb up, but I simply could not hold myself not to slap the +1 here as weel to emphasize how long overdue this actually is ...

[idahogurl]

I cannot believe the age of this feature request. 2012? Guess I will just have to reference the line numbers in my comment.

+1

[hychiuatspireon]

+1 really hope to have this feature implemented 😄

[mystiquewolf]

And here comes another +1.

[HartiganHM]

Why not? +1 👍

[ruben0626]

+1!

[hellhoundsx]

+1 Cmon, this is a super feature

[slaby93]

+1

[infa-erinker]

+1

[Brady-Walker]

+1

[eviktorovich-sc]

+1

[rayman02]

+1

[Bert-R]

👍

[nazarioa]

+1

[Gujarats]

+100 👍

[mccord]

+1

[nswarr]

+1

[rawrgulmuffins]

+1

[hugoz1234]

+1

[yzinkovets]

+1

[brendan-rius]

+1

[rawrgulmuffins]

@Kingdutch It's too late for this comment section. Turn back now before it devours you as well!

[Introvertuous]

I keep hitting plus one, but nothing is happening!

[rhklinux]

+1

[Zeitsperre]

+1

[xhliu]

+1

[vitalijsozornins]

+1

[MykolaMoiseienko]

+1

[codexp]

+1