Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Notes on all /db/ show.erb views #42

Closed
postmodern opened this issue Aug 10, 2023 · 4 comments
Closed

Display Notes on all /db/ show.erb views #42

postmodern opened this issue Aug 10, 2023 · 4 comments
Assignees
Labels
database Database feature New Feature views Views
Milestone

Comments

@postmodern
Copy link
Member

postmodern commented Aug 10, 2023

ronin-db-activerecord 0.2.0 added an notes association to IPAddress, HostName, MACAddress, EmailAddress, URL, etc. All /db/ show.erb views should display notes as Notes. Also add a _notes.erb partial template for rendering a notes Array.

@postmodern postmodern added feature New Feature views Views database Database labels Aug 10, 2023
@postmodern postmodern added this to the 0.1.0 milestone Aug 10, 2023
@postmodern postmodern changed the title Display notes as Comments on all /db/ views Display notes as Comments on all /db/ show.erb views Aug 10, 2023
@postmodern postmodern moved this to Todo in Phase 2 Aug 12, 2023
@postmodern postmodern changed the title Display notes as Comments on all /db/ show.erb views Display Notes on all /db/ show.erb views Nov 1, 2023
@AI-Mozi
Copy link
Member

AI-Mozi commented Nov 1, 2023

Should it be displayed as a table?
Like ID | BODY | CREATED_AT ?
Screenshot 2023-11-01 at 17 41 29

@postmodern
Copy link
Member Author

@AI-Mozi I would assume Notes should be displayed more like Comments would be, but Notes do not have an author/user associated with them. Render the notes text within a div, add the created_at timestamp to either the top or the bottom, and maybe we'll want to eventually add an edit icon to allow editing notes. Also I'm considering whether we should render the Note body as markdown? Maybe the edit button and markdown notes support should be separate issues?

@AI-Mozi
Copy link
Member

AI-Mozi commented Nov 2, 2023

Maybe the edit button and markdown notes support should be separate issues?

I think so. #58

@postmodern
Copy link
Member Author

Implemented by PR #59.

@github-project-automation github-project-automation bot moved this from Todo to Done in Phase 2 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Database feature New Feature views Views
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants