Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary ATT syntax instruction suffix code #227

Closed
postmodern opened this issue Mar 21, 2025 · 1 comment
Closed

Remove unnecessary ATT syntax instruction suffix code #227

postmodern opened this issue Mar 21, 2025 · 1 comment
Assignees
@postmodern
Labels
att-syntax ATT syntax removal Remove code
Milestone
1.0.0

Comments

@postmodern
Copy link
Member

The GNU assembler has supported for a while now omitting the instruction size suffix letter and inferring the operand sizes.

mov  $0xff, %rax

We can safely remove the complex instruction operand size suffix code from X86::Syntax::ATT.format_instruction.
@postmodern postmodern added att-syntax ATT syntax removal Remove code labels Mar 21, 2025
@postmodern postmodern added this to the 1.0.0 milestone Mar 21, 2025
@postmodern postmodern self-assigned this Mar 21, 2025
@postmodern postmodern moved this from Todo to In Progress in ronin-asm refactor Mar 21, 2025
postmodern added a commit that referenced this issue Mar 22, 2025
@postmodern
Support unsized Immediate and Memory types (closes #228,#227).
0a7ce15
@postmodern
Copy link
Member Author

Implemented by 0a7ce15.

@github-project-automation github-project-automation bot moved this from In Progress to Done in ronin-asm refactor Mar 22, 2025
postmodern added a commit that referenced this issue Mar 24, 2025
@postmodern
Support unsized Immediate and Memory types (closes #228,#227).
5937f3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postmodern postmodern

Labels
att-syntax ATT syntax removal Remove code
Projects
ronin-asm refactor
Status: Done
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@postmodern