-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a url keyword or argument to Agent#initialize #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stylistic changes.
I would also copy/paste the @param
tag into lib/ronin/web/browser.rb
for the .new
method.
Also, if it's not too much work, could you rebase against the 0.2.0
branch? I like to merge new features into the next upcoming minor version branch. Otherwise I can manually merge your branch into 0.2.0
.
0bf3412
to
0c1d01a
Compare
25ea81a
to
b18c090
Compare
Thanks for the feedback! Have completed those, rebased against 0.2.0 and updated the base branch of the PR to 0.2.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Looks good except for those two things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last request for change I swear! Did some testing to figure out what values go_to
actually accepts. Turns out URI::HTTP
and anything that Addressable::URI
can accept are valid.
Adds the url: kwarg to the Ronin::Web::Browers::Agent initializer, as outlined in issue #16. Upon initialization the browser will navigate to this url.
Hope this contribution is useful - did my best to conform to code conventions across the rest of the repo. Please do let me know of any changes that are needed. Eager to contribute in any way that might be helpful 👍