Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with Node 12/Win #6

Open
ghost opened this issue Aug 7, 2019 · 1 comment · May be fixed by #8
Open

Build fails with Node 12/Win #6

ghost opened this issue Aug 7, 2019 · 1 comment · May be fixed by #8

Comments

@ghost
Copy link

ghost commented Aug 7, 2019

Hi,

thanks for making this project.

Unfortunately - I'm trying to rebuild the project for Node 12.7 build getting a lot of build errors (*** is used to replace actual paths below, please ignore)

System: Windows 10 1903 64-bit, Node 12.7.0, node-gyp 3.8.0, package: @ronomon/[email protected]

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  binding.cc
  win_delay_load_hook.cc
***\node_modules\@ronomon\utimes\binding.cc(151): error C2660: 'v8::Value::Uint32Value': function does not take 0 arguments [***\node_modules\@ronomon\utimes\build\binding.vcxproj]
  c:\users\***\.node-gyp\12.7.0\include\node\v8.h(2574): note: see declaration of 'v8::Value::Uint32Value' (compiling source file ..\binding.cc)
***\node_modules\@ronomon\utimes\binding.cc(151): error C2789: 'flags': an object of const-qualified type must be initialized [***\node_modules\@ronomon\utimes\build\binding.vcxproj]
  ***\node_modules\@ronomon\utimes\binding.cc(151): note: see declaration of 'flags'
***\node_modules\@ronomon\utimes\binding.cc(152): error C2660: 'v8::Value::IntegerValue': function does not take 0 arguments [***\node_modules\@ronomon\utimes\build\binding.vcxproj]
  c:\users\***\.node-gyp\12.7.0\include\node\v8.h(2572): note: see declaration of 'v8::Value::IntegerValue' (compiling source file ..\binding.cc)
***\node_modules\@ronomon\utimes\binding.cc(152): error C2789: 'btime': an object of const-qualified type must be initialized [***\node_modules\@ronomon\utimes\build\binding.vcxproj]
  ***\node_modules\@ronomon\utimes\binding.cc(152): note: see declaration of 'btime'
***\node_modules\@ronomon\utimes\binding.cc(153): error C2660: 'v8::Value::IntegerValue': function does not take 0 arguments [***\node_modules\@ronomon\utimes\build\binding.vcxproj]
  c:\users\***\.node-gyp\12.7.0\include\node\v8.h(2572): note: see declaration of 'v8::Value::IntegerValue' (compiling source file ..\binding.cc)
***\node_modules\@ronomon\utimes\binding.cc(153): error C2789: 'mtime': an object of const-qualified type must be initialized [***\node_modules\@ronomon\utimes\build\binding.vcxproj]
  ***\node_modules\@ronomon\utimes\binding.cc(153): note: see declaration of 'mtime'
***\node_modules\@ronomon\utimes\binding.cc(154): error C2660: 'v8::Value::IntegerValue': function does not take 0 arguments [***\node_modules\@ronomon\utimes\build\binding.vcxproj]
  c:\users\***\.node-gyp\12.7.0\include\node\v8.h(2572): note: see declaration of 'v8::Value::IntegerValue' (compiling source file ..\binding.cc)
***\node_modules\@ronomon\utimes\binding.cc(154): error C2789: 'atime': an object of const-qualified type must be initialized [***\node_modules\@ronomon\utimes\build\binding.vcxproj]
  ***\node_modules\@ronomon\utimes\binding.cc(154): note: see declaration of 'atime'
gyp ERR! build error
@jorangreef
Copy link
Contributor

Thanks @silverspex, yes @ronomon/utimes needs to switch from NAN to N-API soon.

Jule- added a commit to atomictech/utimes that referenced this issue Dec 18, 2019
@Jule- Jule- linked a pull request Dec 18, 2019 that will close this issue
Vukkk added a commit to Vukkk/utimes that referenced this issue Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant