Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Framework] Refactor crypto encoding hash function #1314

Closed
jolestar opened this issue Jan 19, 2024 · 0 comments · Fixed by #1315
Closed

[Framework] Refactor crypto encoding hash function #1314

jolestar opened this issue Jan 19, 2024 · 0 comments · Fixed by #1315
Assignees
@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Milestone
Rooch v0.3

Comments

@jolestar
Copy link
Contributor

https://github.com/rooch-network/rooch/blob/f7573bb942b956097e0d1f06a61770ee1f8c60f0/crates/rooch-framework/sources/crypto/encoding.move

  1. Make the base58,bech32 general use-case, not only for the Bitcoin address.
  2. Remove the p2sh,p2pkh function.

Update the document #1311
@jolestar jolestar added this to the Rooch v0.3 milestone Jan 19, 2024
ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 pushed a commit that referenced this issue Jan 19, 2024
[gh-1314] generalize base58 and bech32 in rust.
3523aac
Merged
ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 pushed a commit that referenced this issue Jan 22, 2024
[gh-1314] generalize base58 and bech32 in rust.
774969c
ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 pushed a commit that referenced this issue Jan 22, 2024
[gh-1314] add decode algorithm.
56c47d7
ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 pushed a commit that referenced this issue Jan 22, 2024
[gh-1314] adjust encode & decode lengths.
0f78cba
ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 pushed a commit that referenced this issue Jan 22, 2024
[gh-1314] add checksum to bs58 encode function.
535cfc9
ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 pushed a commit that referenced this issue Jan 22, 2024
[gh-1314] update docs.
9ba002c
jolestar pushed a commit that referenced this issue Jan 25, 2024
@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
[gh-1314] refactor crypto encoding hash functions (#1315)
f0fadb9 
* [gh-1314] generalize base58 and bech32 in rust.

* [gh-1314] add decode algorithm.

* [gh-1314] adjust encode & decode lengths.

* [gh-1314] add checksum to bs58 encode function.

* [gh-1314] update docs.

---------

Co-authored-by: Feliciss <[email protected]>
@github-project-automation github-project-automation bot moved this to Done in Rooch Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4

Labels
None yet
Projects
Rooch
Status: Done
Milestone
Rooch v0.3
Development

Successfully merging a pull request may close this issue.

[gh-1314] refactor crypto encoding hash functions rooch-network/rooch
2 participants
@jolestar @ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4