-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[babylon] POC implements rooch finality #2992
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
1667f07
to
8d05c5d
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Files
|
/// The hash of the batch, made by DA | ||
pub batch_hash: H256, | ||
/// The hash of the block, made by DA | ||
pub block_hash: H256, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used batch here, because DA only care about tx list. Not state made by present. If we call it block hash, may hint there is execution inside it? Actually, this hash contains no result of tx execution at all.
Which proposer needs is a hash which combine state and tx itself(state_root & batch_hash)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the block hash in the proposer needs to be associated with the transaction (need to check the block based on tx hash or tx order). This is somewhat different from the batch hash in DA, but it would be best if they could be unified.
Summary
POC implements rooch finality, and equip with babylon finality gadget sidecar, part of Integration babylon #2751