[io] Centralise XRootD EOS URL redirection

The logic to extract the extended attribute 'eos.url.xroot' from a path
to an EOS file on a FUSE mount is centralised in a separate header in
RIO, with an internal function called GetEOSRedirectedXRootUrl. This
function can be called anywhere needed in the rest of ROOT. With this
commit, the following places use this functionality:

- TFile::Open (done before this commit)
- RLoopManager::ChangeSpec (done before this commit)
- RRawFile::Create (introduced in this commit)

In particular the last means introducing the redirection also for
RNTupleReader, which follows a different logic to open the TFile.

Author: vepadulano

io/io/CMakeLists.txt

@@ -21,6 +21,7 @@ if (uring)
 endif ()
 
 ROOT_LINKER_LIBRARY(RIO
+  src/IOUtils.cxx
   src/RConcurrentHashColl.cxx
   src/RFile.cxx
   src/RRawFile.cxx
@@ -79,6 +80,7 @@ set_source_files_properties(src/RConcurrentHashColl.cxx
   PROPERTIES COMPILE_FLAGS -I${CMAKE_SOURCE_DIR}/core/foundation/res)
 
 ROOT_GENERATE_DICTIONARY(G__RIO
+  ROOT/IOUtils.hxx
   ROOT/RConcurrentHashColl.hxx
   ROOT/RFile.hxx
   ROOT/RRawFile.hxx

io/io/inc/ROOT/IOUtils.hxx

@@ -0,0 +1,29 @@
+/*************************************************************************
+ * Copyright (C) 1995-2025, Rene Brun and Fons Rademakers.               *
+ * All rights reserved.                                                  *
+ *                                                                       *
+ * For the licensing terms see $ROOTSYS/LICENSE.                         *
+ * For the list of contributors see $ROOTSYS/README/CREDITS.             *
+ *************************************************************************/
+
+#ifndef ROOT_IO_UTILS
+#define ROOT_IO_UTILS
+
+#include <string>
+#include <optional>
+
+namespace ROOT::Internal {
+
+/// \brief Estimate size of extended attribute on path
+/// \param path Path to the file to check
+/// \param xattr Extended attribute to look for in the file
+/// \return Size of the extended attribute. Positive integer is the size of the attribute, -1 on failure.
+auto GetXAttrSize(std::string_view path, std::string_view xattr);
+
+/// \brief Redirects the input URL to the equivalent XRootD path on EOS
+/// \param inputUrl The input URL to redirect
+/// \return The redirected URL in case of successfull redirection, empty optional otherwise
+std::optional<std::string> GetEOSRedirectedXRootUrl(std::string_view inputUrl);
+} // namespace ROOT::Internal
+
+#endif

io/io/src/IOUtils.cxx

@@ -0,0 +1,60 @@
+#include "ROOT/IOUtils.hxx"
+
+#ifdef R__UNIX
+#ifdef R__FBSD
+#include <sys/extattr.h>
+#else
+#include <sys/xattr.h>
+#endif
+
+#ifdef R__MACOSX
+/* On macOS getxattr takes two extra arguments that should be set to 0 */
+#define getxattr(path, name, value, size) getxattr(path, name, value, size, 0u, 0)
+#endif
+
+#ifdef R__FBSD
+#define getxattr(path, name, value, size) extattr_get_file(path, EXTATTR_NAMESPACE_USER, name, value, size)
+#endif
+
+#include "TEnv.h"
+#endif
+
+auto ROOT::Internal::GetXAttrSize(std::string_view path, std::string_view xattr)
+{
+#ifdef R__UNIX
+   // Assumes the inputs are null-terminated
+   return getxattr(path.data(), attr.data(), nullptr, 0);
+#else
+   (void)path;
+   (void)xattr;
+   return -1;
+#endif
+}
+
+std::optional<std::string> ROOT::Internal::GetEOSRedirectedXRootUrl(std::string_view inputUrl)
+{
+   if (inputUrl.empty())
+      return std::nullopt;
+
+#ifdef R__UNIX
+   // Assumes the input is null-terminated.
+   if (gEnv->GetValue("TFile.CrossProtocolRedirects", 1) == 1) {
+      std::string_view xAttr{"eos.url.xroot"};
+      auto len = ROOT::Internal::GetXAttrSize(inputUrl, xAttr);
+      if (len > 0) {
+         std::string xurl(len, 0);
+         if (getxattr(inputUrl.data(), "eos.url.xroot", &xurl[0], len) == len) {
+            // Sometimes the `getxattr` call may return an invalid URL due
+            // to the POSIX attribute not being yet completely filled by EOS.
+            if (inputUrl.back() != '/') {
+               if (auto baseName = inputUrl.substr(inputUrl.find_last_of("/") + 1);
+                   std::equal(baseName.crbegin(), baseName.crend(), xurl.crbegin())) {
+                  return xurl;
+               }
+            }
+         }
+      }
+   }
+#endif
+   return std::nullopt;
+}

io/io/src/RRawFile.cxx

@@ -20,6 +20,7 @@
 #include "TError.h"
 #include "TPluginManager.h"
 #include "TROOT.h"
+#include "ROOT/IOUtils.hxx"
 
 #include <algorithm>
 #include <cctype> // for towlower
@@ -68,6 +69,8 @@ ROOT::Internal::RRawFile::Create(std::string_view url, ROptions options)
 #ifdef _WIN32
       return std::unique_ptr<RRawFile>(new RRawFileWin(url, options));
 #else
+      if (auto xurl = ROOT::Internal::GetEOSRedirectedXRootUrl(url))
+         return Create(*xurl, options);
       return std::unique_ptr<RRawFile>(new RRawFileUnix(url, options));
 #endif
    }

io/io/src/TFile.cxx

@@ -150,6 +150,7 @@ The structure of a directory is shown in TDirectoryFile::TDirectoryFile
 #include "TThreadSlots.h"
 #include "TGlobal.h"
 #include "ROOT/RConcurrentHashColl.hxx"
+#include "ROOT/IOUtils.hxx"
 #include <memory>
 #include <cinttypes>
 
@@ -3778,34 +3779,16 @@ TFile *TFile::Open(const char *url, Option_t *options, const char *ftitle,
    TString expandedUrl(url);
    gSystem->ExpandPathName(expandedUrl);
 
-#ifdef R__UNIX
-   // If URL is a file on an EOS FUSE mount, attempt redirection to XRootD protocol.
-   if (gEnv->GetValue("TFile.CrossProtocolRedirects", 1) == 1) {
-      TUrl fileurl(expandedUrl, /* default is file */ kTRUE);
-      if (strcmp(fileurl.GetProtocol(), "file") == 0) {
-         ssize_t len = getxattr(fileurl.GetFile(), "eos.url.xroot", nullptr, 0);
-         if (len > 0) {
-            std::string xurl(len, 0);
-            std::string fileNameFromUrl{fileurl.GetFile()};
-            if (getxattr(fileNameFromUrl.c_str(), "eos.url.xroot", &xurl[0], len) == len) {
-               // Sometimes the `getxattr` call may return an invalid URL due
-               // to the POSIX attribute not being yet completely filled by EOS.
-               if (auto baseName = fileNameFromUrl.substr(fileNameFromUrl.find_last_of("/") + 1);
-                   std::equal(baseName.crbegin(), baseName.crend(), xurl.crbegin())) {
-                  if ((f = TFile::Open(xurl.c_str(), options, ftitle, compress, netopt))) {
-                     if (!f->IsZombie()) {
-                        return f;
-                     } else {
-                        delete f;
-                        f = nullptr;
-                     }
-                  }
-               }
-            }
+   if (auto xurl = ROOT::Internal::GetEOSRedirectedXRootUrl(expandedUrl.View())) {
+      if ((f = TFile::Open(xurl->c_str(), options, ftitle, compress, netopt))) {
+         if (!f->IsZombie()) {
+            return f;
+         } else {
+            delete f;
+            f = nullptr;
          }
       }
    }
-#endif
 
    // If a timeout has been specified extract the value and try to apply it (it requires
    // support for asynchronous open, though; the following is completely transparent if

tree/dataframe/src/RLoopManager.cxx

@@ -42,23 +42,8 @@
 #include "ROOT/RSlotStack.hxx"
 #endif
 
-#ifdef R__UNIX
-// Functions needed to perform EOS XRootD redirection in ChangeSpec
-#include "TEnv.h"
+#include "ROOT/IOUtils.hxx"
 #include "TSystem.h"
-#ifndef R__FBSD
-#include <sys/xattr.h>
-#else
-#include <sys/extattr.h>
-#endif
-#ifdef R__MACOSX
-/* On macOS getxattr takes two extra arguments that should be set to 0 */
-#define getxattr(path, name, value, size) getxattr(path, name, value, size, 0u, 0)
-#endif
-#ifdef R__FBSD
-#define getxattr(path, name, value, size) extattr_get_file(path, EXTATTR_NAMESPACE_USER, name, value, size)
-#endif
-#endif
 
 #include <algorithm>
 #include <atomic>
@@ -267,37 +252,20 @@ RLoopManager::RLoopManager(ROOT::RDF::Experimental::RDatasetSpec &&spec)
    ChangeSpec(std::move(spec));
 }
 
-#ifdef R__UNIX
 namespace {
 std::optional<std::string> GetRedirectedSampleId(std::string_view path, std::string_view datasetName)
 {
    // Mimick the redirection done in TFile::Open to see if the path points to a FUSE-mounted EOS path.
    // If so, we create a redirected sample ID with the full xroot URL.
    TString expandedUrl(path.data());
    gSystem->ExpandPathName(expandedUrl);
-   if (gEnv->GetValue("TFile.CrossProtocolRedirects", 1) == 1) {
-      TUrl fileurl(expandedUrl, /* default is file */ kTRUE);
-      if (strcmp(fileurl.GetProtocol(), "file") == 0) {
-         ssize_t len = getxattr(fileurl.GetFile(), "eos.url.xroot", nullptr, 0);
-         if (len > 0) {
-            std::string xurl(len, 0);
-            std::string fileNameFromUrl{fileurl.GetFile()};
-            if (getxattr(fileNameFromUrl.c_str(), "eos.url.xroot", &xurl[0], len) == len) {
-               // Sometimes the `getxattr` call may return an invalid URL due
-               // to the POSIX attribute not being yet completely filled by EOS.
-               if (auto baseName = fileNameFromUrl.substr(fileNameFromUrl.find_last_of("/") + 1);
-                   std::equal(baseName.crbegin(), baseName.crend(), xurl.crbegin())) {
-                  return xurl + '/' + datasetName.data();
-               }
-            }
-         }
-      }
-   }
+   TUrl fileurl(expandedUrl, /* default is file */ kTRUE);
+   if (auto xurl = ROOT::Internal::GetEOSRedirectedXRootUrl(fileurl.GetFile()))
+      return *xurl + '/' + datasetName.data();
 
    return std::nullopt;
 }
 } // namespace
-#endif
 
 /**
  * @brief Changes the internal TTree held by the RLoopManager.
@@ -348,11 +316,10 @@ void RLoopManager::ChangeSpec(ROOT::RDF::Experimental::RDatasetSpec &&spec)
                // is exposed to users via RSampleInfo and DefinePerSample).
                const auto sampleId = files[i] + '/' + trees[i];
                fSampleMap.insert({sampleId, &sample});
-#ifdef R__UNIX
+
                // Also add redirected EOS xroot URL when available
                if (auto redirectedSampleId = GetRedirectedSampleId(files[i], trees[i]))
                   fSampleMap.insert({redirectedSampleId.value(), &sample});
-#endif
             }
          }
          fDataSource = std::make_unique<ROOT::Internal::RDF::RTTreeDS>(std::move(chain), spec.GetFriendInfo());
@@ -370,11 +337,9 @@ void RLoopManager::ChangeSpec(ROOT::RDF::Experimental::RDatasetSpec &&spec)
                fileNames.push_back(files[i]);
                rntupleNames.insert(trees[i]);
 
-#ifdef R__UNIX
                // Also add redirected EOS xroot URL when available
                if (auto redirectedSampleId = GetRedirectedSampleId(files[i], trees[i]))
                   fSampleMap.insert({redirectedSampleId.value(), &sample});
-#endif
             }
          }