Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate TOCTOU races for connect(2) #22

Open
rata opened this issue Mar 10, 2022 · 2 comments
Open

Eliminate TOCTOU races for connect(2) #22

rata opened this issue Mar 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@rata
Copy link

rata commented Mar 10, 2022

The TOCTOU races mentioned in the README can be eliminated if, instead of allowing the connect(2) syscall to continue, we run the syscall on behalf of the container and then just forward the return code & errno.

I mean, we can copy the syscall params and make sure they are out of localhost and such, then we run the syscall.Connect ourselves, and then answer the seccomp notification with the return value & errno we got when running it. In this way, we can chose to run it only when it is safe to do so.

What do you think?

@AkihiroSuda AkihiroSuda added the enhancement New feature or request label Mar 16, 2022
@AkihiroSuda
Copy link
Member

PR is wanted 🙏

@rata
Copy link
Author

rata commented Mar 16, 2022

I'm currently swamped, I don't expect to have time soon. But I'll have a look if I can :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants