Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setting for 0/editorial-team-prep label #102

Open
mpadge opened this issue Jan 5, 2024 · 2 comments
Open

Update setting for 0/editorial-team-prep label #102

mpadge opened this issue Jan 5, 2024 · 2 comments

Comments

@mpadge
Copy link
Collaborator

mpadge commented Jan 5, 2024

@lwasser brought to our attention that the 0/editorial-team-prep label is currently not automatically added. It is removed here:

assign_editor:
message: "The editor guide can be found at https://devguide.ropensci.org/editorguide.html#editorchecklist"
only:
- editors
add_labels:
- 1/editor-checks
remove_labels:
- 0/editorial-team-prep

But never automatically added. We can easily automatically add on initial submission if a pre-sub enquiry can be identified. The question we'd have to resolve would be what to do with initial full submissions? Should we add this label straight away? There is currently no other viable point at which we could automatically do this. Thoughts @noamross @maelle @lwasser?

@noamross
Copy link

noamross commented Jan 5, 2024

I think, on the idea that all submissions should have a tag for their state, this should be added automatically for full submissions.

@lwasser
Copy link

lwasser commented Jan 5, 2024

yes, we current start with a 1/editor-checks but have been thinking about adding a 0/editorial-team-prep type label for new submissions that haven't been "Assigned" yet!

as such i agree with @noamross above

This is what a new submission. looks like for us. but really it should be a 0/editorial-team-prep or 0/review-triage type of label prior to checks as that is it's current state.

Screenshot 2024-01-05 at 12 16 36 PM

xuanxu added a commit that referenced this issue Jun 30, 2024
Remove Node & Gitinspector dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants