Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign_editor responder with "if" conditional on issue template #24

Open
mpadge opened this issue Jul 23, 2021 · 8 comments
Open

assign_editor responder with "if" conditional on issue template #24

mpadge opened this issue Jul 23, 2021 · 8 comments

Comments

@mpadge
Copy link
Collaborator

mpadge commented Jul 23, 2021

This is slightly different to the conditional welcome responder of #23. We have a few different values for submission-type variables which we need to build some conditional logic around, primarily to invoke two different response messages dependent on these variables. Something like:

if:
  value_matches:
    submission-type: "Standard|Estándar" # Can we just grep-or values like that?
   message: "First message"
if:
  value_matches:
    submission-type: "Stats"
   message: "Second message"

And then it's probably good to add

if:
  value_matches:
    submission-type: "Pre-submission|pre-envio"
   message: "Reject message"

@xuanxu Do each of those need a separate responder, or can all three if clauses be combined within a single responder?

@maelle
Copy link
Collaborator

maelle commented Nov 4, 2021

@xuanxu @mpadge what's needed here?

@mpadge
Copy link
Collaborator Author

mpadge commented Nov 4, 2021

Ability for the command @ropensci-review-bot assign <them> as editor to respond with different messages dependent on a template variable. (Specifically Spanish and English messages for those respective templates.)

@maelle
Copy link
Collaborator

maelle commented Jan 3, 2022

@mpadge is this only for this command? Or potentially more?

@mpadge
Copy link
Collaborator Author

mpadge commented Jan 3, 2022

It will also be generally useful in approve responders for the same reasons, as well as in approve responses to Stats submissions, which need to be different from standard approve responses. So yes, definitely more.

@xuanxu
Copy link
Collaborator

xuanxu commented Jan 10, 2022

This require to have system in place to have multilingual templates/messages.
Issue created upstream: openjournals#57

@mpadge
Copy link
Collaborator Author

mpadge commented Sep 20, 2022

@xuanxu any progress here? Absence of this ability is currently leading to a fair bit of failure-prone manual work, so would be good to have implemented, if possible. Thanks

@xuanxu
Copy link
Collaborator

xuanxu commented Sep 22, 2022

any progress here?

Not really, sorry. There have been too many things with higher priority. I'll see if I can fit it in sometime soon, but can't make any promises right now.

@mpadge
Copy link
Collaborator Author

mpadge commented Jun 29, 2023

@xuanxu yet another ping on this issue. We have now started receiving and processing Spanish-language submissions, and it would be great to have the bot also reply in Spanish. Any possibility of this being implemented soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants