Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Submit author response" responder + auto reminder to post said response #72

Open
maelle opened this issue Apr 25, 2022 · 5 comments
Open

Comments

@maelle
Copy link
Collaborator

maelle commented Apr 25, 2022

@mpadge (& others) do you think it'd make sense to have a reminder for the author response 12 days or so after both reviews are in?

It'd however require a way to detect the author response once it's been posted, as the editor might not change the label right away. So should the authors use something like @ropensci-review-bot submit response <url-to-response>? 🤔

@mpadge
Copy link
Collaborator

mpadge commented Apr 25, 2022

Yes! And having a submit response would solve problems that would otherwise arise by requiring authors themselves to define their response. I think something like that would be perhaps the only workable way to implement this.

@maelle maelle changed the title Reminder for author response? "Submit author response" responder + auto reminder to post said response Apr 25, 2022
@maelle
Copy link
Collaborator Author

maelle commented Apr 25, 2022

Thanks @mpadge!

@xuanxu here's a new feature request. 🙏

  • Having a "submit response" responder for authors. @ropensci-review-bot submit response <url to issue comment>.
  • 12 days after the label "4/review(s)-in-awaiting-changes" is applied, post a reminder comment tagging all authors (author1 but also author-others if there are some)
@github-handle please post your response with `@ropensci-review-bot submit response <url to issue comment>`.

Here's the author guide for response. https://devguide.ropensci.org/authors-guide.html

@xuanxu
Copy link
Collaborator

xuanxu commented Jun 22, 2022

@maelle A couple of questions:

  • When the author uses the "submit response" command what should happen?
  • Who can use the command? only the author1 or author-others too?

@maelle
Copy link
Collaborator Author

maelle commented Jun 23, 2022

Who can use the command? only the author1 or author-others too?

Both kinds of authors.

I'll update this thread again when I have a good answer for the first question.

@maelle
Copy link
Collaborator Author

maelle commented Jul 1, 2022

When the author uses the "submit response" command what should happen?

Adding an entry to the authors-response table.
id_no just a unique number
response_date datetime at which the response is submitted
package link to packages table record
URL of response

maelle pushed a commit that referenced this issue Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants