Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exceptions on use of <<- #167

Open
mpadge opened this issue Feb 21, 2023 · 3 comments
Open

Allow exceptions on use of <<- #167

mpadge opened this issue Feb 21, 2023 · 3 comments

Comments

@mpadge
Copy link
Member

mpadge commented Feb 21, 2023

As explained by @bnicenboim in this submission comment ropensci/software-review#573 (comment), the memoise package explicitly recommends assigning all memoised versions of functions to the global namespace, within an .onLoad function. This use could be detected and allowed, instead of current failure for any and all uses of <<-.

@mpadge
Copy link
Member Author

mpadge commented Feb 21, 2023

@bnicenboim The above commits now permits use of <<- when used in .onLoad functions for memoise. Your package still fails because it also uses <<- reticulate::import in .onLoad. This is also now trivial to permit, but I'd first like to think about more general implications of permitting such more general usage. I expect to return to this issue within the week. Thanks

@bnicenboim
Copy link

ok, thanks. I was following the recommendation in "Using reticulate in an R Package" vignette .

@mpadge
Copy link
Member Author

mpadge commented Feb 21, 2023

Re-opening to modify current code to allow any usage of <<- in .onLoad() - and only there! - and to issue a 👀 message instead of ✖️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants