Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow distill vignettes #194

Closed
mpadge opened this issue Jan 29, 2024 · 1 comment
Closed

Allow distill vignettes #194

mpadge opened this issue Jan 29, 2024 · 1 comment

Comments

@mpadge
Copy link
Member

mpadge commented Jan 29, 2024

Current vignette test is:

format <- rmarkdown::default_output_format (f)$name

That works for rendering vignettes with rmarkdown, but not with distill. This leads to failures in ropensci/software-review#623 (comment).

@AAoritz Sorry for the inconvenience; we'll enable your package to pass that check asap.

@maelle Do you want to tackle this one? It'll just require an extra if clause to detect distill instead of rmarkdown, and perform appropriate checks for that.

@mpadge mpadge closed this as completed in b4b8b53 Jan 29, 2024
@mpadge
Copy link
Member Author

mpadge commented Jan 29, 2024

@maelle All good; was an easy fix

mpadge added a commit that referenced this issue Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant