-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapindia: Plot Map of the Indian Subcontinent #670
Comments
Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type |
🚀 Editor check started 👋 |
Checks for mapindia (v1.0.0)git hash: 86413cbb
Important: All failing checks above must be addressed prior to proceeding (Checks marked with 👀 may be optionally addressed.) Package License: MIT + file LICENSE 1. Package DependenciesDetails of Package Dependency Usage (click to open)
The table below tallies all function calls to all packages ('ncalls'), both internal (r-base + recommended, along with the package itself), and external (imported and suggested packages). 'NA' values indicate packages to which no identified calls to R functions could be found. Note that these results are generated by an automated code-tagging system which may not be entirely accurate.
Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running 's <- pkgstats::pkgstats(<path/to/repo>)', and examining the 'external_calls' table. basec (11), tolower (7), data.frame (2), list (2), merge (2), sort (2), sprintf (2), by (1), do.call (1), for (1), if (1), length (1), match (1), nchar (1), return (1), sub (1), which (1) mapindiamap_india (4), mapindia_crs (2), static_merge (2), code_info (1), code_info.character (1), code_info.numeric (1), codes (1), get_code_info (1), map_using_data (1), mapindia_transform (1), mapindia_transform.data.frame (1), mapindia_transform.sf (1), perform_transform (1) utilsdata (9) ggplot2aes (2), `% (1), element_blank (1), geom_sf (1), geom_sf_text (1), theme (1) statsdf (5) mapindiatoolsfetch_codes (3), centroid_labels (1) sfst_as_sf (2), st_transform (1) NOTE: Some imported packages appear to have no associated function calls; please ensure with author that these 'Imports' are listed appropriately. 2. Statistical PropertiesThis package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing. Details of statistical properties (click to open)
The package has:
Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
All parameters are explained as tooltips in the locally-rendered HTML version of this report generated by the The final measure (
2a. Network visualisationClick to see the interactive network visualisation of calls between objects in package 3.
|
id | name | conclusion | sha | run_number | date |
---|---|---|---|---|---|
11673643619 | pages build and deployment | success | d7391d | 13 | 2024-11-04 |
11673613963 | pkgdown.yaml | success | 86413c | 10 | 2024-11-04 |
11673613959 | R-CMD-check.yaml | success | 86413c | 10 | 2024-11-04 |
11673613958 | test-coverage.yaml | success | 86413c | 10 | 2024-11-04 |
3b. goodpractice
results
R CMD check
with rcmdcheck
rcmdcheck found no errors, warnings, or notes
Test coverage with covr
Package coverage: 98.33
Cyclocomplexity with cyclocomp
The following function have cyclocomplexity >= 15:
function | cyclocomplexity |
---|---|
plot_india | 19 |
Static code analyses with lintr
lintr found no issues with this package!
4. Other Checks
Details of other checks (click to open)
✖️ The following function name is duplicated in other packages:
-
codes
from encode, manifestoR, str2str
Package Versions
package | version |
---|---|
pkgstats | 0.2.0.46 |
pkgcheck | 0.1.2.63 |
Editor-in-Chief Instructions:
Processing may not proceed until the items marked with ✖️ have been resolved.
@ropensci-review-bot check package |
Thanks, about to send the query. |
🚀 Editor check started 👋 |
Checks for mapindia (v1.0.0)git hash: 1fd30626
(Checks marked with 👀 may be optionally addressed.) Package License: MIT + file LICENSE 1. Package DependenciesDetails of Package Dependency Usage (click to open)
The table below tallies all function calls to all packages ('ncalls'), both internal (r-base + recommended, along with the package itself), and external (imported and suggested packages). 'NA' values indicate packages to which no identified calls to R functions could be found. Note that these results are generated by an automated code-tagging system which may not be entirely accurate.
Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running 's <- pkgstats::pkgstats(<path/to/repo>)', and examining the 'external_calls' table. basec (11), tolower (7), data.frame (2), list (2), merge (2), sort (2), sprintf (2), by (1), do.call (1), for (1), if (1), length (1), match (1), nchar (1), return (1), sub (1), which (1) mapindiamap_india (4), mapindia_crs (2), static_merge (2), code_info (1), code_info.character (1), code_info.numeric (1), codes (1), get_code_info (1), map_using_data (1), mapindia_transform (1), mapindia_transform.data.frame (1), mapindia_transform.sf (1), perform_transform (1) utilsdata (9) ggplot2aes (2), `% (1), element_blank (1), geom_sf (1), geom_sf_text (1), theme (1) statsdf (5) mapindiatoolsfetch_codes (3), centroid_labels (1) sfst_as_sf (2), st_transform (1) NOTE: Some imported packages appear to have no associated function calls; please ensure with author that these 'Imports' are listed appropriately. 2. Statistical PropertiesThis package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing. Details of statistical properties (click to open)
The package has:
Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
All parameters are explained as tooltips in the locally-rendered HTML version of this report generated by the The final measure (
2a. Network visualisationClick to see the interactive network visualisation of calls between objects in package 3.
|
id | name | conclusion | sha | run_number | date |
---|---|---|---|---|---|
11674083711 | pages build and deployment | NA | b6015f | 14 | 2024-11-04 |
11674058537 | pkgdown.yaml | success | 1fd306 | 11 | 2024-11-04 |
11674058542 | R-CMD-check.yaml | NA | 1fd306 | 11 | 2024-11-04 |
11674058536 | test-coverage.yaml | success | 1fd306 | 11 | 2024-11-04 |
3b. goodpractice
results
R CMD check
with rcmdcheck
rcmdcheck found no errors, warnings, or notes
Test coverage with covr
Package coverage: 98.33
Cyclocomplexity with cyclocomp
The following function have cyclocomplexity >= 15:
function | cyclocomplexity |
---|---|
plot_india | 19 |
Static code analyses with lintr
lintr found no issues with this package!
4. Other Checks
Details of other checks (click to open)
✖️ The following function name is duplicated in other packages:
-
codes
from encode, manifestoR, str2str
Package Versions
package | version |
---|---|
pkgstats | 0.2.0.46 |
pkgcheck | 0.1.2.63 |
Editor-in-Chief Instructions:
This package is in top shape and may be passed on to a handling editor
@shubhamdutta26 There's no need to open new issues. Please just leave this one open, and call |
Hi @shubhamdutta26 - thank you so much for your submission. On first glance, this looks like a very well built package with an important purpose. Mapping, especially state and local regions, is a challenging task, and I like how your package aims to reduce the friction. That said, on my initial pass, I'm not sure if it is a fit for rOpenSci's geospatial score. We tend to focus on software disproportionately aids researchers (versus more general purpose tools) and adds substantial new functionality (versus wrappers). For example:
Again, we have no doubt this package is very useful, but if I understand correctly that functionality is mostly focused on plotting maps and choropleths based on a predetermined set of geographic regions, it may be too small in scope for the time being. If I've misunderstood the package, please let me know. Otherwise, if you're inspired by any of the examples above to extend the package in various ways, please don't hesitate to resubmit and we'd love to take another look. For example (and just for example -- certainly not a comprehensive list): finding ways to generalize to more geographies, output types, functionalities, etc. |
Submitting Author Name: Shubham
Submitting Author Github Handle: @shubhamdutta26
Other Package Authors Github handles: (comma separated, delete if none) @github_handle1, @github_handle2
Repository: https://github.com/shubhamdutta26/mapindia
Version submitted: 1.0.0
Submission type: Standard
Editor: TBD
Reviewers: TBD
Archive: TBD
Version accepted: TBD
Language: en
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
The mapindia package can be used to plot state and district levels maps of the Indian subcontinent. The package also offers convenience functions for plotting choropleths, visualizing spatial data, and handling state/district codes.
Who is the target audience and what are scientific applications of this package?
People who want to work with geospatial data of the Indian subcontinent.
Are there other R packages that accomplish the same thing? If so, how does yours differ or meet our criteria for best-in-category?
To the best of my knowledge, no.
(If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research?
Yes
If you made a pre-submission inquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.
NA
Explain reasons for any
pkgcheck
items which your package is unable to pass.NA
Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
Do you intend for this package to go on CRAN?
Do you intend for this package to go on Bioconductor?
Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
Code of conduct
The text was updated successfully, but these errors were encountered: