Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN checks #494

Closed
Robinlovelace opened this issue Aug 18, 2022 · 3 comments · Fixed by #496
Closed

CRAN checks #494

Robinlovelace opened this issue Aug 18, 2022 · 3 comments · Fixed by #496

Comments

@Robinlovelace
Copy link
Member

Email from CRAN:

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_stplanr.html.

Please correct before 2022-09-01 to safely retain your package on CRAN.

@Robinlovelace
Copy link
Member Author

Heads-up @mpadge I think this is the cause:

stplanr/R/route.R

Lines 206 to 211 in a417dbd

from_id <- unique(verts$id[dodgr::match_pts_to_graph(verts, fm_coords,
connected = TRUE
)])
to_id <- unique(verts$id[dodgr::match_pts_to_graph(verts, to_coords,
connected = TRUE
)])

According to the NEWS for {dodgr}, match_pts_to_graph() renamed to match_pts_to_verts().

Plan: remove support for dodgr for now and revisit when we it's safe to assume most people have updated to the latest version.

Robinlovelace added a commit that referenced this issue Aug 18, 2022
@Robinlovelace Robinlovelace linked a pull request Aug 18, 2022 that will close this issue
@mpadge
Copy link
Member

mpadge commented Aug 19, 2022

@Robinlovelace argh, so sorry about that. Yes, i renamed match_points_to_graph -> match_points_to_verts. I also checked all hard dependencies, but neglected to look at soft deps, so missed stplanr. Please accept my humble apologies on that one!

Ironically, that was done to properly address what was originally an stplanr issue (#331) which led to UrbanAnalyst/dodgr#103, which has now been addressed. "match points to graph" is what the function now does - a proper, super efficient and entirely geometric matching based on line intersections. The previous version was just a cheap vertex matching algorithm, hence the rename. Anyway, sorry.

@Robinlovelace
Copy link
Member Author

Awesome and no worries Mark. Good news: I've resubmitted #496 to CRAN, let's see what happens. V. cool stuff so keen to keep the dodgr soft dep.

Robinlovelace added a commit that referenced this issue Aug 19, 2022
* Update dodgr fun (alternative fix for #494

* Increment version number to 1.0.1

* Update version

* Update urls for cran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants