Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix affiliation matching tests #125

Open
eshadatta-crossref opened this issue Dec 1, 2020 · 3 comments
Open

Fix affiliation matching tests #125

eshadatta-crossref opened this issue Dec 1, 2020 · 3 comments
Labels
maintenance Work needed to maintain long-term health/performance of code and infrastructure

Comments

@eshadatta-crossref
Copy link
Contributor

eshadatta-crossref commented Dec 1, 2020

rorapi.tests_functional.tests_matching.AffiliationMatchingTestCase are failing non-deterministically. Examples of failures include: a fail on the recall and when I ran it locally, a failure on the accuracy:

FAIL: test_matching (rorapi.tests_functional.tests_matching.AffiliationMatchingTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/app/webapp/rorapi/tests_functional/tests_matching.py", line 50, in test_matching
    self.assertTrue(accuracy >= ACCURACY_MIN)
AssertionError: False is not true

Please investigate the test to see if it's a matter of adjusting the value or if something else needs to be tweaked (indexing, matching or something else). If the affiliation matching could be run over the set of the various versions of GRID that we have to see if there's a degradation, that would be really useful.

@mariagould mariagould added the search improvements Improving search functionality in ROR label Mar 1, 2022
@lizkrznarich lizkrznarich added maintenance Work needed to maintain long-term health/performance of code and infrastructure and removed search improvements Improving search functionality in ROR labels Jan 17, 2023
@lizkrznarich lizkrznarich changed the title Investigate affiliation matching Fix affiliation matching tests Jan 17, 2023
@mariagould mariagould moved this to Maintenance in ROR Inbox Aug 15, 2024
@JeremyBrent
Copy link

We're testing the ROR API locally, and getting this error as well:

======================================================================
FAIL: test_matching (rorapi.tests.tests_functional.tests_matching_v1.AffiliationMatchingTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/app/webapp/rorapi/tests/tests_functional/tests_matching_v1.py", line 53, in test_matching
    self.assertTrue(accuracy >= ACCURACY_MIN)
AssertionError: False is not true

Our logs show accuracy is:
Accuracy: 0.762 (0.7356054625748849, 0.7883945374251151)

@adambuttrick
Copy link
Contributor

@JeremyBrent for bug reports, we use https://github.com/ror-community/ror-roadmap. I've created as an issue here, but feel free to elaborate or correct if I haven't captured correctly.

@JeremyBrent
Copy link

Thank you @adambuttrick 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Work needed to maintain long-term health/performance of code and infrastructure
Projects
Status: Maintenance
Development

No branches or pull requests

6 participants