From 6ca3a5b891fabae862129dc614e5e7dc07ee03bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Fr=C3=B6hlich?= Date: Tue, 14 May 2024 13:57:27 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota --- Makefile | 6 +++--- make_help_scripts/fix_index.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 642fd1fdf9f..f1670ba7310 100644 --- a/Makefile +++ b/Makefile @@ -81,7 +81,7 @@ multiversion: Makefile @echo Step 3: Deleting temporary commits ./make_help_scripts/delete_tmp_commits.py @echo Step 4: Create correct index + legacy master version - ./make_help_scripts/fix_index.py --builddir $(BUILDDIR) + ./make_help_scripts/fix_index.py --build-dir $(BUILDDIR) multiversion-with-errors: Makefile @echo Building multi version documentation without API @@ -92,7 +92,7 @@ multiversion-with-errors: Makefile @echo Step 3: Deleting temporary commits ./make_help_scripts/delete_tmp_commits.py @echo Step 4: Create correct index + legacy master version - ./make_help_scripts/fix_index.py --builddir $(BUILDDIR) + ./make_help_scripts/fix_index.py --build-dir $(BUILDDIR) multiversion-with-api: Makefile @echo Building multi version documentation with API @@ -107,7 +107,7 @@ multiversion-with-api: Makefile @echo Step 5: Building multiversion API ./make_help_scripts/create_api_multi_version.py @echo Step 6: Create correct index + legacy master version - ./make_help_scripts/fix_index.py --builddir $(BUILDDIR) + ./make_help_scripts/fix_index.py --build-dir $(BUILDDIR) .PHONY: help Makefile html-with-errors html-with-api multiversion multiversion-with-api multiversion-with-errors html-all-subrepos html-all-subrepos-with-api html-all-subrepos-with-errors linkcheck-all-subrepos-with-api diff --git a/make_help_scripts/fix_index.py b/make_help_scripts/fix_index.py index 91e897b64c5..36b16b339f7 100755 --- a/make_help_scripts/fix_index.py +++ b/make_help_scripts/fix_index.py @@ -33,7 +33,7 @@ def fix_index(base_branch, builddir): if __name__ == "__main__": parser = argparse.ArgumentParser(description='Fix index.') - parser.add_argument('--builddir', required=True, help='Build directory.') + parser.add_argument('--build-dir', required=True, help='Build directory.') args = parser.parse_args() - fix_index(deploy_defines.base_branch, args.builddir) + fix_index(deploy_defines.base_branch, args.build_dir)