Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizing Eigen Argument Types #78

Open
jcarpinelli-bdai opened this issue Jun 25, 2024 · 0 comments
Open

Generalizing Eigen Argument Types #78

jcarpinelli-bdai opened this issue Jun 25, 2024 · 0 comments

Comments

@jcarpinelli-bdai
Copy link

I'm trying to use the kinematics_interface with Eigen::Map types, and Eigen::Block types. In some cases, this produces unnecessary copies. In other cases, the result fails to compile, so users need to convert static arrays to Eigen::Dynamic, or other conversions. According to the Eigen's documentation, "Eigen: Writing Functions Taking Eigen Types as Parameters", functions can more simply handle multiple Eigen types with function templates, or functions can accept an Eigen::Ref container type which allows for matrices and blocks of matrices.

Do you think changing argument types in this interface is worth consideration? I know that's a very breaking change, but I think it would be useful to be able to pass multiple Eigen types to any kinematics_interface implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant