Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velocity is unavailable in effort_controllers/JointPositionController #544

Open
leaf0810 opened this issue Dec 17, 2020 · 1 comment
Open
Labels

Comments

@leaf0810
Copy link

In joint_position_controller.h ,there is

struct Commands
  {
    double position_; // Last commanded position
    double velocity_; // Last commanded velocity
    bool has_velocity_; // false if no velocity command has been specified
  };

but in joint_position_controller.cpp,

void JointPositionController::setCommandCB(const std_msgs::Float64ConstPtr& msg)
{
  setCommand(msg->data);
}

the parameter is only one!
why not apply velocity interface?

@matthew-reynolds
Copy link
Member

Looks like something that was added in 2013 (#35) to lay the groundwork in case anyone wanted to build on it later, but no one ever found it necessary to use the feature so it's been sitting there untouched ever since (Except for a small bugfix in #52).

If it's something you need, please consider opening a PR and describing the usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants