Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable doc jobs to know their ROS_DISTRO #1077

Open
tfoote opened this issue Dec 7, 2024 · 0 comments · May be fixed by #1078
Open

Enable doc jobs to know their ROS_DISTRO #1077

tfoote opened this issue Dec 7, 2024 · 0 comments · May be fixed by #1078

Comments

@tfoote
Copy link
Member

tfoote commented Dec 7, 2024

We currently don't have the ROS_DISTRO encoded and available for rosdoc2 jobs available.

ros-infrastructure/rosdoc2#161 now enables it to query rosdistro for repository urls if it is unset. However there are likely more improved features we could enable.

The devel and build jobs gets it by forcing the installation of ros-workspace package aka ros-rolling-ros-workspace but that is not a good mechanism for rosdoc2 builds. Because the jobs are explicitly parameterized we could just add ROS_DISTRO to the environment to be available for processing. Is there any objections to that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant