Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort up ROS parameters for filter chains #199

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Sort up ROS parameters for filter chains #199

merged 2 commits into from
Jul 23, 2024

Conversation

bjsowa
Copy link
Contributor

@bjsowa bjsowa commented Jul 17, 2024

Cherry picked from #195

  • Explicitly declare all parameters , otherwise get_parameter won't work.
  • Remove unused parameters.
  • Add read-only flag to all parameters as the filter chains don't support dynamically changing them.

@bjsowa bjsowa mentioned this pull request Jul 17, 2024
Merged
@jonbinney jonbinney self-assigned this Jul 17, 2024
jonbinney
jonbinney approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jonbinney jonbinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Setting them all to read only makes sense - if we ever implement updating for them, we can change that.

@jonbinney
Copy link
Contributor

Thanks for this!

@jonbinney jonbinney merged commit eaaaeab into ros-perception:ros2 Jul 23, 2024
5 checks passed
@bjsowa bjsowa deleted the sort-up-ros-parameters branch July 23, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbinney jonbinney jonbinney approved these changes

Assignees

@jonbinney jonbinney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjsowa @jonbinney