-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling release? #25
Comments
I think this is a @SteveMacenski question - I can certainly do a release - but he's more in tune with what is going on in ROS2 navigation and so I'd want him to say we should do a release. |
I don't intend to maintain any use of |
Whether you use rolling or not, we're basing galactic off of rolling initially, so if you don't update it now, you'll probably have to update it in galactic. But it's certainly up to you. |
Oh, I think I was confused by the removal of the other package, but @mabelzhang FYI as well. |
Did we reach a conclusion? I think Steve has voted in favor of a release? I see no problem either. |
@wjwwood you may do a release for rolling if |
I think rolling was seeded automatically from foxy. Seems like we can do a release (perhaps also to foxy?). I'll let you guys sort out what you'd like to do. |
So I don't understand why we'd need to re-release to foxy? There is no difference between A release to |
No you're right, foxy is good to go. I missed that there was a ros2 and foxy branch. Too many repositories on my mind... sorry.
I don't know why that's an issue, but that is the case for http://repo.ros2.org/status_page/ros_rolling_default.html?q=map_msgs
The details are laid out here: https://www.ros.org/reps/rep-2002.html You could opt-out, but then people using rolling wouldn't get it, and you'd have more work to do when galactic releases. I suppose it's a trade-off. I guess you can raise concerns about it in one of these places:
Looks like you commented on the REP, but maybe this reality wasn't conveyed properly? |
I know we're off topic here now (but resolution: feel free to run a sync), but I guess I missed that detail while reading the REP or I didn't process what that would mean for maintainers. For msgs packages like this, I don't mind that logic. I'm more concerned about any non-msgs packages I maintain that were added. By automatically enrolling maintainers, they could be genuinely unaware of it. While I was aware of rolling, I now have actually no idea which or what packages I maintain are now in rolling to even be aware that I should be syncing them to rolling or directly to the distribution. I think this was a bit of an oversight on the introduction of rolling. I think every package that was automatically transitioned over should get an Else, I think years from now there will still be people unaware their projects were moved to rolling and they release into |
You should really cross link that to one of the places I mentioned above so other people can weigh in. (As you said kind of off topic for this issue) |
This is a good point, done https://discourse.ros.org/t/notify-rolling-maintainers-theyve-been-automatically-enrolled/19562 |
We're preparing to fork rolling into galactic and we noticed there are changes on the default branch that have not been released yet: 2.0.2...ros2
@mikeferguson @DLu do either of you have time to evaluate whether or not a released needs to happen and make it? If you find it does need a release but do not have time to do it, let me know and we'll try to do a release for you.
The text was updated successfully, but these errors were encountered: