Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-name required for linting large metapackage project #368

Open
SteveMacenski opened this issue Jan 6, 2024 · 3 comments
Open

package-name required for linting large metapackage project #368

SteveMacenski opened this issue Jan 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@SteveMacenski
Copy link

Description

** clear and concise description of the bug is **

I'm looking to add the linter stage to Nav2, which contains a large number of growing packages

Expected Behavior

** clear and concise description of what you expected to happen **

Not have to manually specify each

Actual Behavior

** clear and concise description of what actually happened. include copied logs whenever possible **

Have to manually specify each package-name

Additional context

** Add any other context about the problem here **

Can this not simply test for all set linters for all packages it finds?

@SteveMacenski SteveMacenski added the bug Something isn't working label Jan 6, 2024
@SteveMacenski SteveMacenski changed the title package-name required package-name required for linting large metapackage project Jan 6, 2024
@SteveMacenski
Copy link
Author

A wildcard in strings works "*", can that not just be made the default? EZ-PZ solution

@christophebedard
Copy link
Member

Seems like a useful change that wouldn't break any existing workflows. The only downside is that, if you're building ROS 2 from source along with your package(s), it would run linters on all those packages too. However, that's only one use-case, and you can just manually specify the package names in that case.

Would you be willing to submit a PR? Otherwise I can get to it eventually.

@SteveMacenski
Copy link
Author

#369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants