-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(rqt_console) (nice-to-have) move filtering classes to common pkgs #30
Comments
I'm writing filtering function (for this enhancement) and noticed that one tiny detail that prohibits generalization is |
Could you elaborate a bit more what the issue currently is and how that should to be improved? Based on the issue title, the two comments and the referenced other issue I can not comprehend what this issue is about. |
This is an enhancement, not an issue. I found that the filtering feature that Nevermind the issue I referenced in the 1st comment. |
I think the filter funtionality is very specific in console. What other plugin would you consider adding such an elaborate filter to? Unless we can define what would need it I think it would be best to close this as wont fix. |
I don't have time to look at carefully but I thought I made (Isn't making general API good idea in general btw? ) |
Yes it is I just didn't see anywhere someone would want to use it. If you used it in rqt reconfigure I'm all for moving it out at some point for reduced code duplication. But as you said low priority. |
This issue was moved to ros-visualization/rqt_console#1 |
I know it wasn't intended when
rqt_console
was initially written to make all those filter classes to be generic. But it would be very beneficial to have a set of filtering components that provide multiple types of filters and users can select / de-select them on GUI while system aggregates the result from all selected filters (likerqt_console
does).The text was updated successfully, but these errors were encountered: