-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open source rewrite of rqt_topic #46
Comments
cc @cottsay @DorianScholz too since you guys are listed as maintainers |
I'm happy to give over the maintainer role, but I suggest to get an ok from someone at open robotics. @wjwwood |
👍 |
It's effectively orphaned atm, we really don't have the time to properly manage it beyond replying to requests like this. I think I can add you as a maintainer, and I'll bring it up at the ROS 2 meeting. The only thing I can think of is that we'll want to make sure that any tutorial material is updated as needed for your changes, since this tool is used in some of the beginner tutorials if I'm not mistaken. |
I should say, we're always looking for help with maintenance, even for a short time to make a big change, but it really should be up to @methylDragon who's listed as the maintainer in ROS 2 atm. |
Thanks guys for the responses here - I'll work on spinning out a PR this next week after CES. Hopefully you guys will like it 😅😆 |
@DorianScholz @DLu @wjwwood apologies for the delay here - was a busy week after CES. Rewrite is here #47, though I still need to fix the tests after open-sourcing it 👍🏼 |
@wjwwood not sure who the maintainer is of this repo but I've got approval to open source our (Apex.AI's) version of rqt_topic.
It's a major rewrite and most likely would be easiest with one big PR.
Before making it I first wanted to check if it'd even be accepted here.
Also, not sure if it's possible but I could also be added as a maintainer here for the repo if it is now orphaned.
Just let me know how you'd like to proceed - excited to give it back to the community!
The text was updated successfully, but these errors were encountered: