diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 010a9015..298a20b4 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -3,7 +3,7 @@ on: pull_request: push: branches: - - ros2 + - ros2-jazzy schedule: # Run every week at 20:00 on Sunday - cron: "0 20 * * 0" @@ -18,17 +18,23 @@ jobs: cppcheck, cpplint, flake8, - pep257, + # pep257, TODO: enable when we fixed + # Error: diagnostic_common_diagnostics/diagnostic_common_diagnostics/ntp_monitor.py:113 in public method `ntp_diag`: D417: Missing argument descriptions in the docstring (argument(s) st are missing descriptions in 'ntp_diag' docstring) + # using ros-rolling-ament-pep257 amd64 0.18.0-1noble.20240426.150718 uncrustify, xmllint, ] - runs-on: ubuntu-22.04 + include: + - distro: jazzy + os: ubuntu-24.04 + runs-on: ${{ matrix.os }} env: AMENT_CPPCHECK_ALLOW_SLOW_VERSIONS: 1 steps: - uses: actions/checkout@v1 - uses: ros-tooling/setup-ros@master - - run: sudo pip install pydocstyle==6.1.1 # downgrade to fix https://github.com/ament/ament_lint/pull/428 + with: + required-ros-distributions: ${{ matrix.distro }} - uses: ros-tooling/action-ros-lint@master with: linter: ${{ matrix.linter }} diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 9fbcd295..524aed6d 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -22,14 +22,12 @@ jobs: ] include: - distro: jazzy - os: ubuntu-22.04 + os: ubuntu-24.04 runs-on: ${{ matrix.os }} steps: - uses: ros-tooling/setup-ros@master - - run: | - sudo pip install pydocstyle==6.1.1 # downgrade to fix https://github.com/ament/ament_lint/pull/428 - sudo pip install pip --upgrade - sudo pip install pyopenssl --upgrade # fix for AttributeError: module 'lib' has no attribute 'X509_V_FLAG_CB_ISSUER_CHECK' + with: + required-ros-distributions: ${{ matrix.distro }} - uses: ros-tooling/action-ros-ci@master with: target-ros2-distro: ${{ matrix.distro }}