Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper QoS profiles for sensor messages #28

Closed
bigdayangyu opened this issue Jun 19, 2019 · 2 comments
Closed

Proper QoS profiles for sensor messages #28

bigdayangyu opened this issue Jun 19, 2019 · 2 comments

Comments

@bigdayangyu
Copy link

The current cartographer_ros node.cc uses rmw_qos_profile_default as QoS profile for all sensor messages. It might be more appropriate to use rmw_qos_profile_sensor_data profile.
@Karsten1987

subscribers_[trajectory_id].push_back(
{SubscribeWithHandler<sensor_msgs::msg::Imu>(&Cartographer::HandleImuMessage,
trajectory_id, topic,
node_handle_, this, rmw_qos_profile_default),
topic});
}
if (options.use_odometry) {
std::string topic = topics.odometry_topic;
subscribers_[trajectory_id].push_back(
{SubscribeWithHandler<nav_msgs::msg::Odometry>(&Cartographer::HandleOdometryMessage,
trajectory_id, topic,
node_handle_, this, rmw_qos_profile_default),
topic});
}
if (options.use_nav_sat) {
std::string topic = topics.nav_sat_fix_topic;
subscribers_[trajectory_id].push_back(
{SubscribeWithHandler<sensor_msgs::msg::NavSatFix>(&Cartographer::HandleNavSatFixMessage,
trajectory_id, topic,
node_handle_, this, rmw_qos_profile_default),
topic});
}
if (options.use_landmarks) {
std::string topic = topics.landmark_topic;
subscribers_[trajectory_id].push_back(
{SubscribeWithHandler<cartographer_ros_msgs::msg::LandmarkList>(&Cartographer::HandleLandmarkMessage,
trajectory_id, topic,
node_handle_, this, rmw_qos_profile_default),
topic});

@clalancette
Copy link

Yes, that may be the case. When I did the initial port, I was having some trouble with that, but that was probably an error on my part. I'd welcome a pull request that did that, but I'd want to see some results from testing before we merged.

@Karsten1987 Karsten1987 mentioned this issue Jun 21, 2019
@clalancette
Copy link

This was actually done in #29, so I'm going to close this out. Feel free to reopen if this doesn't work for you. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants