Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yaml types #781

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Use yaml types #781

wants to merge 1 commit into from

Conversation

InvincibleRMC
Copy link
Contributor

I notice yaml was given a #type: ignore but that is no longer necessary with python3-types-pyaml

@InvincibleRMC
Use yaml types
1a44ebe 
Signed-off-by: Michael Carlstrom <[email protected]>
fujitatomoya
fujitatomoya approved these changes May 23, 2024
View reviewed changes
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

having accurate type annotations helps type checkers with python3-types-pyyaml, we do not need to have type hinting directive to ignore any type checking for yaml anymore.

@fujitatomoya
Copy link

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link

@InvincibleRMC can you address https://ci.ros2.org/job/ci_linux/21236/testReport/junit/launch.test/test_mypy/test_mypy/?

@InvincibleRMC
Copy link
Contributor Author

Strange it cannot find types-pyaml error: Library stubs not installed for "yaml" [import-untyped]

@InvincibleRMC
Copy link
Contributor Author

Hmm I might be wrong but looking at this we might need to add the install in ros2ci itself.

@InvincibleRMC InvincibleRMC mentioned this pull request Jun 6, 2024
Open
@InvincibleRMC
Copy link
Contributor Author

Made a pr over at ros2/ci#781 to hopefully address this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@methylDragon methylDragon Awaiting requested review from methylDragon

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees

@clalancette clalancette

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvincibleRMC @fujitatomoya @clalancette