Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Node interfaces support #112

Open
wodtko opened this issue Feb 12, 2024 · 2 comments
Open

[ADD] Node interfaces support #112

wodtko opened this issue Feb 12, 2024 · 2 comments
Assignees

Comments

@wodtko
Copy link

wodtko commented Feb 12, 2024

At work, we have been using message filters for a while now.
While transitioning to LifecycleNodes, we noticed that the interface of the message subscriber still relies on a Node type, which supports create_subscription with a specific signature.
The intended way of the rclcpp::NodeInterfaces seems to circumvent the use of any Node type and use specific interfaces instead.

We are currently working on implementing similar changes in other projects (see image_transport and image_transport_plugins).
This is why we depend on similar changes here.

Are there any reasons against such a change?
Since we (especially @authaldo) are working on it anyway, we would be happy to contribute a PR.

@mjcarroll
Copy link
Member

No reasons against the change, likely just a lack of someone contributing the feature. Please open a PR and we would be happy to iterate on it.

@wodtko
Copy link
Author

wodtko commented Feb 12, 2024

awesome, thanks for the fast reply, @authaldo created a respective PR #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants