Name remapping specific to a fully-qualified node's name #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add this to the remapping design doc? Similarly to what was done in ros2/design#299 for #837. Particularly, this change looks good to me (I haven't checked the implementation yet). |
ivanpauno
added
enhancement
Yes, I'll create a new PR for the remapping design doc for the FQN after ros2/design#299 is merged because some examples seem to be changed. |
iuhilnehc-ynos
force-pushed
the
topic-remap-fully-qualified-node-name
branch
from
09491ea
to
8a90f74
Compare
Not to support __node and __ns that will break API Signed-off-by: Chen Lihui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
Signed-off-by: Chen Lihui [email protected]