Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: get clients, servers info #371

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

leeminju531
Copy link
Contributor

Add get clients, servers info

Refer to ros2/ros2cli#916

@leeminju531
Copy link
Contributor Author

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in rmw service endpoints are handled as topics internally, precisely client is DataReader and server is DataWriter to fill in the topic endpoint information. so all the field of rmw_topic_endpoint_info_t can be filled in with calling the graph cache.

IMO i think in rmw we can use rmw_topic_endpoint_info_t as it is now, but i would add comment that says this structure is used for service client and server as well.

rmw/include/rmw/get_topic_endpoint_info.h Outdated Show resolved Hide resolved
rmw/include/rmw/get_topic_endpoint_info.h Outdated Show resolved Hide resolved
rmw/include/rmw/get_topic_endpoint_info.h Outdated Show resolved Hide resolved
rmw/include/rmw/get_topic_endpoint_info.h Outdated Show resolved Hide resolved
@sloretz
Copy link
Contributor

sloretz commented Jul 12, 2024

@wjwwood Mind taking a look at this new rmw API 🧇 ?

@methylDragon
Copy link
Contributor

@leeminju531 , any updates from your end?

@leeminju531
Copy link
Contributor Author

@methylDragon @fujitatomoya, Updated with underlying implementations first:).

@fujitatomoya
Copy link
Collaborator

@leeminju531 thanks for putting the effort on this.

i will do the another review once they are ready, so please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants