From 6eab1ecf6764799e61b74735130e20cea490dbf8 Mon Sep 17 00:00:00 2001 From: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Date: Mon, 20 Jul 2020 09:32:51 -0700 Subject: [PATCH] Use foxy testing apt repos to install linters for Actions (#463) * Use foxy testing apt repos to install linters for Actions Signed-off-by: Emerson Knapp --- .github/workflows/lint.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 4be1b3130f..13aaadb6fa 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,8 +1,4 @@ # Run linters automatically on pull requests. -# -# ros-tooling/actino-ros-lint is relying on the latest APT binary packages. -# As of 2020-05-01, Eloquent is the latest release for which APT binary -# packages are available, which is why the Docker image is based on Eloquent. name: Lint rosbag2 on: pull_request: @@ -12,7 +8,7 @@ jobs: name: ament_copyright runs-on: ubuntu-latest container: - image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest + image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest steps: # TODO(setup-ros-docker#7): calling chown is necessary for now - run: sudo chown -R rosbuild:rosbuild "$HOME" . @@ -20,6 +16,7 @@ jobs: - uses: ros-tooling/action-ros-lint@0.0.6 with: linter: copyright + distribution: foxy package-name: | ros2bag rosbag2_compression @@ -34,7 +31,7 @@ jobs: name: ament_xmllint runs-on: ubuntu-latest container: - image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest + image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest steps: # TODO(setup-ros-docker#7): calling chown is necessary for now - run: sudo chown -R rosbuild:rosbuild "$HOME" . @@ -42,6 +39,7 @@ jobs: - uses: ros-tooling/action-ros-lint@0.0.6 with: linter: xmllint + distribution: foxy package-name: | ros2bag rosbag2 @@ -57,12 +55,12 @@ jobs: ament_lint_cpp: # Linters applicable to C++ packages name: ament_${{ matrix.linter }} runs-on: ubuntu-latest - container: - image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest strategy: fail-fast: false matrix: linter: [cppcheck, cpplint, uncrustify] + container: + image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest steps: # TODO(setup-ros-docker#7): calling chown is necessary for now - run: sudo chown -R rosbuild:rosbuild "$HOME" . @@ -70,6 +68,7 @@ jobs: - uses: ros-tooling/action-ros-lint@0.0.6 with: linter: ${{ matrix.linter }} + distribution: foxy package-name: | rosbag2_compression rosbag2_converter_default_plugins @@ -83,7 +82,7 @@ jobs: name: ament_${{ matrix.linter }} runs-on: ubuntu-latest container: - image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest + image: rostooling/setup-ros-docker:ubuntu-focal-ros-foxy-ros-base-testing-latest strategy: fail-fast: false matrix: @@ -95,5 +94,6 @@ jobs: - uses: ros-tooling/action-ros-lint@0.0.6 with: linter: ${{ matrix.linter }} + distribution: foxy package-name: | ros2bag