Address review nitpicks

Signed-off-by: Emerson Knapp <[email protected]>
ros2 · Mar 26, 2020 · fd8b7fe · fd8b7fe
1 parent 383089b
commit fd8b7fe
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/rosbag2_storage/include/rosbag2_storage/topic_metadata.hpp b/rosbag2_storage/include/rosbag2_storage/topic_metadata.hpp
@@ -25,7 +25,7 @@ struct TopicMetadata
   std::string name;
   std::string type;
   std::string serialization_format;
-  // std::vector<rclcpp::QoS> serialized to YAML string
+  // Serialized std::vector<rclcpp::QoS> as a YAML string
   std::string offered_qos_profiles;
 
   bool operator==(const rosbag2_storage::TopicMetadata & rhs) const

diff --git a/...ag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp b/...ag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp
@@ -231,7 +231,7 @@ void SqliteStorage::fill_topics_and_types()
 
   for (auto result : query_results) {
     all_topics_and_types_.push_back(
-      {std::get<0>(result), std::get<1>(result), std::get<2>(result), {}});
+      {std::get<0>(result), std::get<1>(result), std::get<2>(result), ""};
   }
 }
 
@@ -273,7 +273,7 @@ rosbag2_storage::BagMetadata SqliteStorage::get_metadata()
   for (auto result : query_results) {
     metadata.topics_with_message_count.push_back(
       {
-        {std::get<0>(result), std::get<1>(result), std::get<2>(result), {}},
+        {std::get<0>(result), std::get<1>(result), std::get<2>(result), ""},
         static_cast<size_t>(std::get<3>(result))
       });
 

diff --git a/rosbag2_transport/src/rosbag2_transport/qos.hpp b/rosbag2_transport/src/rosbag2_transport/qos.hpp
@@ -38,7 +38,7 @@ class Rosbag2QoS : public rclcpp::QoS
 {
 public:
   Rosbag2QoS()
-  : rclcpp::QoS(10) {}
+  : rclcpp::QoS(0) {}  // 0 history depth is always overwritten on deserializing
   explicit Rosbag2QoS(const rclcpp::QoS & value)
   : rclcpp::QoS(value) {}
 };

diff --git a/rosbag2_transport/src/rosbag2_transport/recorder.cpp b/rosbag2_transport/src/rosbag2_transport/recorder.cpp
@@ -29,7 +29,6 @@
 
 #include "generic_subscription.hpp"
 #include "rosbag2_node.hpp"
-#include "qos.hpp"
 
 namespace rosbag2_transport
 {