Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Organize Unit Tests #319

Open
superjax opened this issue Nov 8, 2018 · 1 comment
Open

Re-Organize Unit Tests #319

superjax opened this issue Nov 8, 2018 · 1 comment
Assignees

Comments

@superjax
Copy link
Contributor

superjax commented Nov 8, 2018

I wrote most of the unit tests, and recently looked through them and have decided that they are horrific. I'm glad they are there (they just caught a potential optimization no-no in @dpkoch's code) but they need to be reworked.

@superjax superjax self-assigned this Nov 8, 2018
@dpkoch
Copy link
Contributor

dpkoch commented Nov 9, 2018

Agreed. This will probably require rewriting some of our code to actually enable unit tests (instead integration tests, which is largely what all of our tests are now). This will probably best be done as part of our planned interface implementation refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants