Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary built from source reports wrong version #374

Open
Georacer opened this issue Feb 5, 2020 · 1 comment
Open

Binary built from source reports wrong version #374

Georacer opened this issue Feb 5, 2020 · 1 comment

Comments

@Georacer
Copy link

Georacer commented Feb 5, 2020

Hello everyone!

I have built rosflight from source, as per the instructions. Works quite well so far on the bench.
I have compiled from ''master'' which I have verified.
However, when ran, the AP would report that it is

[ INFO] [1580927169.107349452] [/rosflight_io]: Firmware version: v1.1.0-461-g51c8049f

I know that v1.2.0 exists since:

$ git tag
v0.1.0
v1.0.0
v1.0.0-beta.1
v1.0.1
v1.1.0
v1.2.0

However, the AP message checks out since the command which creates (#156) it returns:

$ git describe --tags --always
v1.1.0-461-g51c8049

Do you know why git does this behaviour? Is it normal?

Thanks in advance!

@bsutherland333
Copy link
Contributor

I've actually noticed similar behavior, we'll probably want to resolve this before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Do Later
Development

No branches or pull requests

2 participants