Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

octomap_msgs, version conflict with message_generation #51

Open
gonzalezsieira opened this issue Mar 19, 2018 · 3 comments · May be fixed by #54
Open

octomap_msgs, version conflict with message_generation #51

gonzalezsieira opened this issue Mar 19, 2018 · 3 comments · May be fixed by #54

Comments

@gonzalezsieira
Copy link

Hi:

I've tried to use the latest version of octomap_msgs (0.3.2), but it seems to be an issue with the dependency message_generation which results in a conflict.

This is declared in the pom.xml of 0.3.2:

<dependency>
      <groupId>org.ros.rosjava_bootstrap</groupId>
      <artifactId>message_generation</artifactId>
      <version>[0.1,0.2)</version>
      <scope>runtime</scope>
</dependency>

Since latest version of message_generation is 0.3.0, it is impossible to use this package. However, when looking into version 0.3.1 of octomap_msgs, the dependency has no upper limit:

<version>[0.1,)</version>

If there is no reason for it, I think the upper limit should be removed from the pom.xml file in version 0.3.2 too.

Regards,

@jubeira
Copy link

jubeira commented Mar 23, 2018

Hi @gonzalezsieira, thanks for the report.
There might have been a mistake when publishing the version 3.2; that dependency range shouldn't be like this.

The range should be [0.3, 0.4) to keep up the consistency with semantic versioning. I will take a look at it when I have some time.

@gonzalezsieira
Copy link
Author

Thanks so much for your reply. I appreciate your effort in maintianing this repository.

Also, if would be great if you could take a look to the dependency of guava that is declared in message_generation. Required version is 12.0 (quite old in these days), and it might be in conflict with other projects using newer versions of this library. I think this should be changed to [12.0, ), if possible.

Regards,

@jubeira
Copy link

jubeira commented Mar 27, 2018

That sounds good too; patch versions should be kept open in general. I'm a bit busy this week and the next one; if you send a PR with only those two changes I will approve them. Otherwise, you can wait a bit :)

gonzalezsieira added a commit to gonzalezsieira/rosjava_mvn_repo that referenced this issue Mar 28, 2018
@gonzalezsieira gonzalezsieira linked a pull request Apr 5, 2018 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants