Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequence not incremented. #7

Open
rednexela1941 opened this issue May 26, 2023 · 0 comments · May be fixed by #8
Open

sequence not incremented. #7

rednexela1941 opened this issue May 26, 2023 · 0 comments · May be fixed by #8

Comments

@rednexela1941
Copy link

The sequence variable is defined here:

sequence = 0

And goes through a 0 + 0 operation :

sequence += sequence

And is not touched anywhere else. This messes with OpENer here:
https://github.com/EIPStackGroup/OpENer/blob/5375e60e9d80a297db7ce47c4129e1a57c50b191/source/src/cip/cipioconnection.c#L922

Because it never thinks any new data is coming in.

Fix seems to be sequence += 1.

@rednexela1941 rednexela1941 linked a pull request May 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant