Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy topic does not respect topic names #68

Open
pdeziel opened this issue Sep 28, 2023 · 0 comments
Open

Destroy topic does not respect topic names #68

pdeziel opened this issue Sep 28, 2023 · 0 comments
Labels
bug Something isn't working hacktoberfest

Comments

@pdeziel
Copy link
Collaborator

pdeziel commented Sep 28, 2023

Describe the bug
Currently, the destroy_topic function in ensign.py only has the ability to destroy a topic if a user passes in a topic_id. It should be flexible enough to be able to destroy the topic by name as well.

To Reproduce

import asyncio
from pyensign.ensign import Ensign

async def destroy():
    ensign = Ensign()
    await ensign.destroy_topic("topic")

asyncio.run(destroy())

Dataset
Did you use a specific dataset to produce the bug? Where can we access it?

Expected behavior
I expected the topic to be destroyed, instead I got an error

Traceback

pyensign.exceptions.EnsignInvalidArgument: received gRPC error from Ensign: INVALID_ARGUMENT: invalid id field ((3, 'invalid argument'))

Desktop (please complete the following information):

  • OS: macOS
  • Python Version [e.g. 2.7, 3.10, miniconda]
  • PyEnsign Version [e.g. 1.1]

Additional context
Add any other context about the problem here.

@pdeziel pdeziel added bug Something isn't working hacktoberfest labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant