Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double loads, regex warnings, and cleanup, oh my! #1961

Open
zenspider opened this issue May 10, 2023 · 3 comments · May be fixed by #1962
Open

Double loads, regex warnings, and cleanup, oh my! #1961

zenspider opened this issue May 10, 2023 · 3 comments · May be fixed by #1962

Comments

@zenspider
Copy link
Contributor

Hi hi hi... I'm poking at switching over to rogue and when ruby warnings are on (via ruby -w or $-w = true, or just plain rake spec w/ the right config), the project SPEWS. 331 lines worth to be clear...

Some (lots) of the output is ruby warning about duplicate regexp ranges and has pointed out a number of buggy regexps... not just duplicate ranges, but regexps that can't actually work right.

I'd like to clean it up (mostly done). Y'all interested?
@zenspider
Copy link
Contributor Author

eg https://github.com/rouge-ruby/rouge/blob/master/lib/rouge/lexers/ada.rb#L158

@zenspider
Copy link
Contributor Author

Down to the following:

lib/rouge/lexers/julia.rb:255: warning: character class has duplicated range: /[\p{L}\p{Nl}\p{S}_][\p{Word}\p{S}\p{Po}!]*/

which might be smarter than me

@zenspider zenspider linked a pull request May 11, 2023 that will close this issue
Open
@zenspider
Copy link
Contributor Author

I'm not alone here: https://www.reddit.com/r/ruby/comments/12sshf1/doesnt_anybody_use_w/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Zenspider/warnings double loads and fixes zenspider/rouge
1 participant
@zenspider