Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tag font face #32

Open
DivineDominion opened this issue May 19, 2022 · 5 comments
Open

Introduce tag font face #32

DivineDominion opened this issue May 19, 2022 · 5 comments

Comments

@DivineDominion
Copy link

Somewhat related to #5, what do you think about defining a svg-tag-face that inherits from :default but allows users to customize if needed?

Am asking because with my default font setting, the tags are a bit on the larger side:

image

Would like to make them 80% height or so. And my main font is monospaced, but for tags I'd prefer variable width.

(If there are no objections I can also try to add that myself and propose a PR)

@DivineDominion DivineDominion changed the title Introduce Introduce tag font May 19, 2022
@DivineDominion DivineDominion changed the title Introduce tag font Introduce tag font face May 19, 2022
@rougier
Copy link
Owner

rougier commented May 19, 2022

You should be able to specify a different face with :face . Do you mean it is not working?

@DivineDominion
Copy link
Author

@rougier I was thinking of changing the default in https://github.com/rougier/svg-tag-mode/blob/main/svg-tag-mode.el#L165-L166 to svg-tag-face to globally change all tags, instead of having to adjust each call to svg-tag-make and similar. So not a bug report, just an idea for convenience

@rougier
Copy link
Owner

rougier commented May 23, 2022

Like a svg-tag-mode-default-face?

@DivineDominion
Copy link
Author

@rougier Yeah, something like that! (Not sure about naming conventions so I cannot suggest anything here with confidence :))

@rougier
Copy link
Owner

rougier commented May 25, 2022

Done (svg-tag-default-face) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants