New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coc/message/reader.py read_string should return as string not bytes #3

Open

akirarat opened this issue Oct 17, 2016 · 0 comments

Contributor

akirarat commented Oct 17, 2016

Since reader is just a BufferedReader. self.read() will return a byte array. We should convert this into a UTF-8 string.

def read_string(self):
    length = self.read_int()
    if length == pow(2, 32) - 1:
        return b""
    else:
        try:
            decoded = self.read(length)
        except MemoryError:
            raise IndexError("String out of range.")
        else:
            return decoded

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment