Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
pio
crate.$crate
so that they don't break when reexported.This has two benefits:
pio
instead ofpio+pio_proc
.pio
so the user doesn't even need to depend onpio
directly, and they get the right version automatically. This has been a source of pain inembassy-rp
when using git versions.This commit shows the changes needed for HAL and user code. Works nicely. embassy-rs/embassy@65f00c5
Unfortunately to do this I've had to move the data structures to a new
pio-core
crate. Otherwisepio-proc
andpio
would have a circular dependency.fixes #70
depends on #71