From 0b81e79786f0e16a4caa953265b1ce9cdfab252a Mon Sep 17 00:00:00 2001 From: Jonathan Pallant Date: Wed, 13 Nov 2024 16:48:04 +0000 Subject: [PATCH] Change DefaultIrqHandler to spin, not panic. Also it doesn't need to be unsafe. --- rp235x-hal/src/arch.rs | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/rp235x-hal/src/arch.rs b/rp235x-hal/src/arch.rs index 1fa9bffbd..05aa88d08 100644 --- a/rp235x-hal/src/arch.rs +++ b/rp235x-hal/src/arch.rs @@ -473,16 +473,15 @@ mod inner { /// Our default IRQ handler. /// - /// Just panics. - /// - /// # Safety - /// - /// Do not call this function - it is called automatically when our - /// `MachineExternal` interrupt handler can't find anything better to call. + /// Just spins. #[no_mangle] #[allow(non_snake_case)] - unsafe fn DefaultIrqHandler() { - panic!(); + fn DefaultIrqHandler() { + // Spin, so you can attach a debugger if you get stuck here. + // This is the also the default functionality used in cortex-m-rt. + loop { + crate::arch::nop(); + } } }