Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishlist: get git revision of other folders #67

Open
ferdymercury opened this issue Jul 12, 2021 · 1 comment
Open

wishlist: get git revision of other folders #67

ferdymercury opened this issue Jul 12, 2021 · 1 comment

Comments

@ferdymercury
Copy link

I often have small projects where I include big external libraries that are themselves git repositories in /opt.
In those cases, it would be nice to 'read' the commit sha of those folders.

To achieve that, I guess that this line should take a variable argument, (with default value as now):
https://github.com/rpavlik/cmake-modules/blob/main/GetGitRevisionDescription.cmake#L87

@ferdymercury
Copy link
Author

ferdymercury commented Jul 12, 2021

This works for me, but is backward-incompatible. Not sure if there is a way to specify a default argument to get the old behavior:
ferdymercury@c4e57ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant