From 30c769764e1863c07f3db50a34c2f0dc79ca12a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ale=C5=A1=20Mat=C4=9Bj?= Date: Thu, 19 Sep 2024 05:31:01 -0400 Subject: [PATCH] Fix deserialization when checking signals `object_path` Since https://github.com/rpm-software-management/dnf5/pull/1679 `sdbus::ObjectPath` is send over to the client not std::string. This was causing the check `signature_valid(sdbus::Signal &)` to crash, the client callback ended and the server kept waiting for result of the `key_import` userconfirm. --- dnf5daemon-client/callbacks.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dnf5daemon-client/callbacks.cpp b/dnf5daemon-client/callbacks.cpp index 5e66be388..e4e35d9bf 100644 --- a/dnf5daemon-client/callbacks.cpp +++ b/dnf5daemon-client/callbacks.cpp @@ -36,7 +36,7 @@ namespace dnfdaemon::client { bool DbusCallback::signature_valid(sdbus::Signal & signal) { // check that signal is emitted by the correct session object - std::string object_path; + sdbus::ObjectPath object_path; signal >> object_path; return object_path == context.get_session_object_path(); }