-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnf5 CLI does not handle emojis (and potentially other unicode symbols?) in %description #1685
Comments
@musicinmybrain said in the Fedora Python matrix channel:
|
I just tried this on Fedora 40:
and got (excerpted):
Now, these are merely Unicode bullets, The above works fine with |
There are also differences in localization, which kind of worked in
(Don’t try other locales for now; I just fixed an issue with the other localized descriptions in the I guess this should be filed as a separate issue. |
dnf5 version 5.1.17 does not use locale. |
Hmm, thanks for that! It does look like this works in Fedora 41. Both the Unicode bullets from |
It turns out, however, that setting |
Is it a dnf problem? Can you please take a look at #1687 (comment) |
Indeed, as described in #1687 (comment), there are two things going on:
So I think that at least with respect to this bug, |
(Deleted a comment that was inaccurate because I did an experiment in a mock chroot that I had forgotten to clean first.) |
We can try to improve it. If the locale setting fails, then instead of the |
Can this be backported to the dnf5 version in Fedora 40 as well? |
If there aren’t any pitfalls I’m overlooking, this seems like a good idea and a solid improvement. |
I don't think that falling to C.UTF-8 is great idea. If a user has a terminal in non-UTF-8 mode, he asks for e.g. ja_JP.EUCJP end DNF5 starts spitting out UTF-8 characters, it wil bodge his terminal. If glibc reverted a default locale from C.UTF-8 back to C, there was probably a good reason for it. I would rather use nl_langfinfo() to retrieve current locale code set and print that in the error message. Or rather not mentioning "C" locale at all. |
@ppisar dnf4 is also trying a fallback to Or the user will be a However, you could try tweaking the fallback in your PR to set the |
I'm not sure. The current plan is to backport anything related to dnf5 to Fedora 40 or lower only if there is a strong reason to do so. |
The uv package's description in Fedora has emojis in it, which dnf5 does not handle correctly. See the difference between
dnf5 repoquery
anddnf5 info
's output:The text was updated successfully, but these errors were encountered: