Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf5-automatic command_format does not pass {body} anymore #1951

Closed
Szpadel opened this issue Dec 13, 2024 · 1 comment · Fixed by #1972
Closed

dnf5-automatic command_format does not pass {body} anymore #1951

Szpadel opened this issue Dec 13, 2024 · 1 comment · Fixed by #1972

Comments

@Szpadel
Copy link

Szpadel commented Dec 13, 2024

With dnf5-automatic {body} inside command_format is not replaced with update summary.

/etc/dnf/automatic.conf:

[command]
command_format = "curl https://example.com -F title=dnf-automatic -F message={body}"

Results in {body} message being submitted instead of update content.

This looks like regression introduced with dnf5, as it worked correctly with dnf4
evan-goode added a commit to evan-goode/dnf5 that referenced this issue Dec 20, 2024
@evan-goode
automatic: Substitute variables in command_format
9035d53 
{body} was not substituted correctly in `command_format` for the command
emitter.

Resolves rpm-software-management#1951
@evan-goode evan-goode mentioned this issue Dec 20, 2024
Merged
evan-goode added a commit to evan-goode/ci-dnf-stack that referenced this issue Dec 20, 2024
@evan-goode
automatic: Test command_format variable expansion
b71da77 
Requires rpm-software-management/dnf5#1972.

For rpm-software-management/dnf5#1951.
@evan-goode evan-goode mentioned this issue Dec 20, 2024
Merged
@evan-goode
Copy link
Member

Thank you for filing an issue! #1972 should fix this.

github-merge-queue bot pushed a commit that referenced this issue Jan 2, 2025
@evan-goode @ppisar
automatic: Substitute variables in command_format
a2d0ab6 
{body} was not substituted correctly in `command_format` for the command
emitter.

Resolves #1951
ppisar pushed a commit to rpm-software-management/ci-dnf-stack that referenced this issue Jan 6, 2025
@evan-goode @ppisar
automatic: Test command_format variable expansion
f9cd636 
Requires rpm-software-management/dnf5#1972.

For rpm-software-management/dnf5#1951.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

automatic: Substitute variables in command_format evan-goode/dnf5
2 participants
@Szpadel @evan-goode